Skip to content

ndmp: remove ndmp backup level limit#2188

Merged
BareosBot merged 6 commits intobareos:masterfrom
florian-at-bareos:dev/fburger/fix-ndmp-incrementals
Mar 3, 2025
Merged

ndmp: remove ndmp backup level limit#2188
BareosBot merged 6 commits intobareos:masterfrom
florian-at-bareos:dev/fburger/fix-ndmp-incrementals

Conversation

@florian-at-bareos
Copy link
Contributor

@florian-at-bareos florian-at-bareos commented Feb 20, 2025

Thank you for contributing to the Bareos Project!

The maximum incremental level for ndmp backups is arbitrarily limited to 8 in bareos.
This PR removes this limit and also adjusts the ndmp system test to do 10 incremental backups instead of 1.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
    Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@florian-at-bareos florian-at-bareos self-assigned this Feb 20, 2025
@florian-at-bareos florian-at-bareos added this to the 25.0.0 milestone Feb 20, 2025
@florian-at-bareos florian-at-bareos linked an issue Feb 20, 2025 that may be closed by this pull request
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code/test changes are great! I would like to see some hint added to our ndmp documentation about the 9 incremental restriction/guarantee of ndmp, so that people can figure out why their incrementals backups do not work once they go over their hardwares limit.

@florian-at-bareos florian-at-bareos changed the title ndmp: remove arbitrary incremental limit ndmp: remove bareos ndmp backup level limit Feb 27, 2025
@florian-at-bareos florian-at-bareos changed the title ndmp: remove bareos ndmp backup level limit ndmp: remove ndmp backup level limit Feb 27, 2025
@BareosBot BareosBot force-pushed the dev/fburger/fix-ndmp-incrementals branch from 382e255 to d7718c6 Compare March 3, 2025 08:39
@BareosBot BareosBot merged commit 13c0881 into bareos:master Mar 3, 2025
@arogge arogge mentioned this pull request Apr 14, 2025
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot take more than 8 NDMP Incrementals

4 participants