ndmp: remove ndmp backup level limit#2188
Merged
BareosBot merged 6 commits intobareos:masterfrom Mar 3, 2025
Merged
Conversation
sebsura
requested changes
Feb 24, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
The code/test changes are great! I would like to see some hint added to our ndmp documentation about the 9 incremental restriction/guarantee of ndmp, so that people can figure out why their incrementals backups do not work once they go over their hardwares limit.
sebsura
requested changes
Feb 26, 2025
sebsura
approved these changes
Mar 3, 2025
Fixes bareos#2081: Cannot take more than 8 NDMP Incrementals
382e255 to
d7718c6
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
The maximum incremental level for ndmp backups is arbitrarily limited to 8 in bareos.
This PR removes this limit and also adjusts the ndmp system test to do 10 incremental backups instead of 1.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality
Tests