config: deprecate file daemon as alias for client in FD config#2187
Merged
BareosBot merged 8 commits intobareos:masterfrom Mar 18, 2025
Merged
Conversation
Contributor
Author
|
still requires documentation changes |
sebsura
reviewed
Feb 21, 2025
sebsura
requested changes
Feb 24, 2025
docs/manuals/source/Appendix/Howtos/BackupOfThirdPartyDatabases.rst.inc
Outdated
Show resolved
Hide resolved
sebsura
requested changes
Feb 28, 2025
sebsura
approved these changes
Mar 5, 2025
650ca83 to
46a1a9e
Compare
ad9ff64 to
0ceeed9
Compare
Fixes bareos#219: deprecate File Daemon resource in FD configuration This is necessary because otherwise one cannot comprehend whether FileDaemon or Client resource was specified. Also output a warning if aliases are used.
Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
0ceeed9 to
48796c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Deprecates the FileDaemon Resource in the FD configuration.
This is done by introducing aliases to config resources.
If you have a "FileDeamon" resource in the FD, you get a warning saying that the usage of aliases for resources is discouraged and that you should use "Client" instead.
This is done analogous to #2159 .
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality