Merged
Conversation
c8854a1 to
1a64e3a
Compare
3c748ae to
4fb640b
Compare
773b7d5 to
2b32538
Compare
8944769 to
8be4a67
Compare
0f2cd6e to
6695184
Compare
81d79a6 to
13d6992
Compare
910246e to
3f70d24
Compare
dc5e339 to
8ece24b
Compare
sebsura
approved these changes
May 12, 2025
sebsura
requested changes
May 12, 2025
4f32447 to
1f65ea3
Compare
use cmake_minimum_required(VERSION <min>...<max>) to bulk-enable all the policies up to and including those introduced in CMake version <max>.
we know these currently won't work correctly, so building them is currently discouraged and disabled. If anyone needs this, she can easily patch the CMakeLists.txt to remove the error.
these tests tend to fail randomly on busy systems. Increasing the timeout should help to make the test more reliable.
Add a helper function for the tedious "if windows, configure file and add to the target's sources".
as we always build with OpenSSL and have TLS enabled, the settings and code to build with these disabled can be safely removed.
as we require ZLIB for building, we don't need these conditionals anywhere in the build.
Remove HAVE_PQISTHREADSAFE which was always set to 1. Also remove POSTGRESQL_BATCH_FILE_INSERT that is now unused.
as this cannot be determined ahead-of-time for every build/platform it is probably better to rely on CTEST_PARALLEL_LEVEL being set in the environment. Thus, instead of statically setting this to 10, we force 5 for sanitizer builds and otherwise set it to 10 unless the user has set CTEST_PARALLEL_LEVEL in the environment.
this is required as setting test properties on gtests is now not possible anymore.
this seems to be unused and the directories we're pointing at do not exist anymore. Also, the old specfiles for OBS are not needed anymore.
this removes most of the OPENSSL_VERSION_NUMBER checks.
so we can nicely hide the detail of requiring `-lcam` on FreeBSD.
while this is not truly required nowadays, we should have it on everything that handles dynamic loading.
f603d7c to
3f02297
Compare
we now use HAVE_GFAPI everywhere and fixed HAVE_GFAPI being actually available, which was broken in a previous cleanup commit. This also removes support for the legacy 2-argument version of glfs_ftruncate().
* remove BACKEND_OBJECTS * remove unneeded link_libraries that will be added transitively anyway * put re-used sources into STATIC libraries
by returning the created files from bareos_configure_file() this function could be simplified a lot.
this regularly hits OOM when built with ASAN as it runs a lot of jobs.
3f02297 to
5e4820d
Compare
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR tries to clean up cmake.
The main goal is to leverage target-dependencies instead of plain library-links. As we linked plain libraries instead of targets by mistake, the PR should also make this impossible.
For debugging our project now supports a flag
DEBUG_TARGET_DEPENDENCIESthat will dump (hopefully helpful) information about target dependencies into the binary dir.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality