cmake: add cmake_parse_arguments policy CMP0174#2169
Merged
BareosBot merged 2 commits intobareos:masterfrom Feb 14, 2025
Merged
Conversation
joergsteffens
approved these changes
Feb 11, 2025
57a8ff1 to
fcd0f5f
Compare
Contributor
Author
|
Hi @joergsteffens Andreas lead me to even simpler way to fix the issue. As @arogge mention to me in chat, with this method we didn't carefully review each new policy coming in between cmake 3.19 and 3.31. |
7 tasks
joergsteffens
approved these changes
Feb 12, 2025
Contributor
|
@bruno-at-bareos you will need to add the changes from 9134b30 to the bareoscopydllstobindir for this to compile. |
fcd0f5f to
4f62699
Compare
- fix issue bareos/internal#189 warning with cmake 3.31 in cmake_parse_arguments policy CMP0174 - add fixes in @skcore/cmake/BareosCopyDllsToBinDir.cmake about new CMP0175 Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
043c306 to
037e427
Compare
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fix issue bareos/internal#189 warning with cmake 3.31 in
cmake_parse_arguments.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality