Skip to content

cmake: add cmake_parse_arguments policy CMP0174#2169

Merged
BareosBot merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/fix-cmake_parse_arguments-policy
Feb 14, 2025
Merged

cmake: add cmake_parse_arguments policy CMP0174#2169
BareosBot merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/fix-cmake_parse_arguments-policy

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Feb 11, 2025

This PR fix issue bareos/internal#189 warning with cmake 3.31 in
cmake_parse_arguments.

-- ✓ system:spool (baseport=30591)
--      └─ ✓ system:spool
CMake Warning (dev) at systemtests/cmake/BareosSystemtestFunctions.cmake:673 (cmake_parse_arguments):
  The COMMENT keyword was followed by an empty string or no value at all.
  Policy CMP0174 is not set, so cmake_parse_arguments() will unset the
  ARG_COMMENT variable rather than setting it to an empty string.
Call Stack (most recent call first):
  systemtests/cmake/BareosSystemtestFunctions.cmake:846 (add_disabled_systemtest)
  systemtests/tests/stresstest/CMakeLists.txt:21 (create_systemtest)
This warning is for project developers.  Use -Wno-dev to suppress it.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@joergsteffens joergsteffens added this to the 25.0.0 milestone Feb 11, 2025
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/fix-cmake_parse_arguments-policy branch from 57a8ff1 to fcd0f5f Compare February 12, 2025 14:48
@bruno-at-bareos
Copy link
Contributor Author

bruno-at-bareos commented Feb 12, 2025

Hi @joergsteffens Andreas lead me to even simpler way to fix the issue.
I've redone the commit and #2172 is also created for 24.

As @arogge mention to me in chat, with this method we didn't carefully review each new policy coming in between cmake 3.19 and 3.31.
What I can say bareos code build (without any warnings) and I've 655 tests marked as passed.
and Jenkins seems happy to build all (we have an unrelated error for windows still)

@sebsura
Copy link
Contributor

sebsura commented Feb 13, 2025

@bruno-at-bareos you will need to add the changes from 9134b30 to the bareoscopydllstobindir for this to compile.

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/fix-cmake_parse_arguments-policy branch from fcd0f5f to 4f62699 Compare February 13, 2025 09:52
bruno-at-bareos and others added 2 commits February 14, 2025 00:44
- fix issue bareos/internal#189 warning with cmake 3.31 in
  cmake_parse_arguments policy CMP0174
- add fixes in @skcore/cmake/BareosCopyDllsToBinDir.cmake
  about new CMP0175

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@BareosBot BareosBot force-pushed the dev/bruno/master/fix-cmake_parse_arguments-policy branch from 043c306 to 037e427 Compare February 14, 2025 00:44
@BareosBot BareosBot merged commit 7bf9efe into bareos:master Feb 14, 2025
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/fix-cmake_parse_arguments-policy branch July 24, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants