windows: fix readlink buffer size issue#2153
Merged
BareosBot merged 8 commits intobareos:masterfrom Feb 10, 2025
Merged
Conversation
This if does not make sense here
We allocated too little memory to hold the information we wanted to have. We reserved 544 bytes total, which left 524 bytes for the PathBuffer. This buffer contains two paths: The print name and the substitute name. Each can (probably) contain up to 260*2 bytes, e.g. 1040 bytes total. This means that the function would fail for very long strings and would crash for certain strings as we try to write to one-past the path (which would be ok if we made sure to allocate enough space!) On our cd/ci infrastructure, we hit exactly that issue: The PathBuffer used up _exactly_ all bytes given, leading to the crash!
florian-at-bareos
suggested changes
Feb 7, 2025
Contributor
florian-at-bareos
left a comment
There was a problem hiding this comment.
Looks very good, thanks for your work!
florian-at-bareos
approved these changes
Feb 7, 2025
We should make sure to only accept requests from the client once the global state (con) is completely setup, otherwise we risk deferencing an invalid optional.
9640f83 to
1132e96
Compare
This was referenced Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When encountering a symlink on windows, we try to discover the real path by allocating a fixed size buffer and handing it to windows.
The problem is that this buffer may not be big enough! If the buffer is too small, then the function will just outright fail, but if the buffer is just big enough, then the client may crash as we try to write some bytes past the end of the section that windows just wrote, i.e. outside the allocated buffer in this case.
This PR also includes a fix for our grpc test module. The module did not create the connection in the right order leading to failed tests.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality