Skip to content

contrib: check_chunk.py improve README.md instructions#2147

Merged
BareosBot merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/fix-check_chunk-documentation
Feb 12, 2025
Merged

contrib: check_chunk.py improve README.md instructions#2147
BareosBot merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/fix-check_chunk-documentation

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Feb 3, 2025

This PR aims to include all review comments of PR#1790

  • add installation instructions
  • add restricted console and profile

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
    Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@bruno-at-bareos bruno-at-bareos self-assigned this Feb 3, 2025
@bruno-at-bareos bruno-at-bareos added this to the 25.0.0 milestone Feb 3, 2025
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/fix-check_chunk-documentation branch from 432bdf9 to d78b98a Compare February 3, 2025 16:04
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your work! This reads much better now

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/fix-check_chunk-documentation branch from d78b98a to 3a03948 Compare February 10, 2025 12:40
bruno-at-bareos and others added 2 commits February 12, 2025 19:38
- add installation instructions
- add restricted console and profile

Include all reviews comments of PR#1790

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@BareosBot BareosBot force-pushed the dev/bruno/fix-check_chunk-documentation branch from 3b545c4 to 16b1a56 Compare February 12, 2025 19:39
@BareosBot BareosBot merged commit 99ffe64 into bareos:master Feb 12, 2025
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/fix-check_chunk-documentation branch July 24, 2025 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants