systemtests: fail if daemons have config warnings#2144
Merged
BareosBot merged 10 commits intobareos:masterfrom Feb 12, 2025
Merged
systemtests: fail if daemons have config warnings#2144BareosBot merged 10 commits intobareos:masterfrom
BareosBot merged 10 commits intobareos:masterfrom
Conversation
77b677f to
46d0e6d
Compare
sebsura
requested changes
Jan 31, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
This looks very good! You should also add some developer documentation about this feature!
Contributor
Author
|
this feature is not yet documented |
sebsura
requested changes
Feb 3, 2025
sebsura
requested changes
Feb 5, 2025
docs/manuals/source/DeveloperGuide/BuildAndTestBareos/systemtests.rst
Outdated
Show resolved
Hide resolved
sebsura
approved these changes
Feb 7, 2025
Fixes bareos#131: Add automated check for configuration issues in systemtest configurations One can disable this behaviour for each systemtest individually by setting the IGNORE_DAEMON_CONFIG_WARNINGS (CACHE INTERNAL) to true at the beginning of the systemtests CMakeLists.txt file.
Note that the systemtest 'parallel-jobs' requires config directives that
omit warnings ('MaximumConcurrentJobs' and 'MaximumBlockSize').
a8bece9 to
e40911c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #issue131: Add automated check for configuration issues in systemtest
configurations
One can disable this behaviour for each systemtest individually by
passing the IGNORE_CONFIG_WARNINGS option to
create_systemtest.Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality