plugin: postgresql use integer for savepkt.object_index#2132
Merged
BareosBot merged 2 commits intobareos:masterfrom Jan 23, 2025
Conversation
sebsura
requested changes
Jan 22, 2025
8bdec8a to
3972ca0
Compare
sebsura
requested changes
Jan 22, 2025
3972ca0 to
c212cb3
Compare
sebsura
approved these changes
Jan 22, 2025
7 tasks
In previous commit, object_index was initialized with current_time_ns() which can return value over integer limit. To avoid any risk of unsorted restores, we move back to integer. We recommend to redo a full after installing this update. - added detection of misordered objectindex during restore in testrunner-default Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
d046200 to
574b312
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In previous commit,
object_indexwas initialized withcurrent_time_ns()which can return value over integer limit.To avoid any risk of unsorted restores, we move back to integer.
We recommend to redo a full after installing this update.
testrunner-default
Signed-off-by: Bruno Friedmann bruno.friedmann@bareos.com
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests