Skip to content

plugin: postgresql use integer for savepkt.object_index#2132

Merged
BareosBot merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/fix-plugin-postgresql-rop-objectindex-as-integer
Jan 23, 2025
Merged

plugin: postgresql use integer for savepkt.object_index#2132
BareosBot merged 2 commits intobareos:masterfrom
bruno-at-bareos:dev/bruno/master/fix-plugin-postgresql-rop-objectindex-as-integer

Conversation

@bruno-at-bareos
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos commented Jan 22, 2025

In previous commit, object_index was initialized with
current_time_ns() which can return value over integer limit.

To avoid any risk of unsorted restores, we move back to integer.

We recommend to redo a full after installing this update.

  • added detection of misordered objectindex during restore in
    testrunner-default

Signed-off-by: Bruno Friedmann bruno.friedmann@bareos.com

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/fix-plugin-postgresql-rop-objectindex-as-integer branch from 8bdec8a to 3972ca0 Compare January 22, 2025 12:58
@bruno-at-bareos bruno-at-bareos force-pushed the dev/bruno/master/fix-plugin-postgresql-rop-objectindex-as-integer branch from 3972ca0 to c212cb3 Compare January 22, 2025 13:25
bruno-at-bareos and others added 2 commits January 23, 2025 17:05
In previous commit, object_index was initialized with
current_time_ns() which can return value over integer limit.

To avoid any risk of unsorted restores, we move back to integer.

We recommend to redo a full after installing this update.

- added detection of misordered objectindex during restore in
  testrunner-default

Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
@BareosBot BareosBot force-pushed the dev/bruno/master/fix-plugin-postgresql-rop-objectindex-as-integer branch from d046200 to 574b312 Compare January 23, 2025 17:05
@BareosBot BareosBot merged commit f0171f2 into bareos:master Jan 23, 2025
@bruno-at-bareos bruno-at-bareos deleted the dev/bruno/master/fix-plugin-postgresql-rop-objectindex-as-integer branch January 27, 2025 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants