Skip to content

python-bareos: Add missing dh-python build dep#2130

Merged
BareosBot merged 4 commits intobareos:masterfrom
AlexanderS:python-builddep
Feb 10, 2025
Merged

python-bareos: Add missing dh-python build dep#2130
BareosBot merged 4 commits intobareos:masterfrom
AlexanderS:python-builddep

Conversation

@AlexanderS
Copy link
Contributor

@AlexanderS AlexanderS commented Jan 21, 2025

The python-bareos debian package uses pybuild as build system. dh-python is a mandatory build dependency. So this should be in the debian/control file.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault
    The python-bareos debian package uses pybuild as build system. dh-python is a
    mandatory build dependency. So this should be in the debian/control file.

Copy link
Contributor

@florian-at-bareos florian-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thank you!

@sebsura
Copy link
Contributor

sebsura commented Feb 3, 2025

@AlexanderS do you want to add yourself to the AUTHORS file ?

@AlexanderS
Copy link
Contributor Author

@AlexanderS do you want to add yourself to the AUTHORS file ?

Thanks, I added myself to the AUTHORS file.

AlexanderS and others added 4 commits February 10, 2025 09:26
The python-bareos debian package uses pybuild as build system. dh-python
is a mandatory build dependency. So this should be in the debian/control
file.
@BareosBot BareosBot merged commit a209450 into bareos:master Feb 10, 2025
@AlexanderS AlexanderS deleted the python-builddep branch February 10, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants