Skip to content

debian: Add missing build dependencies#2128

Merged
BareosBot merged 2 commits intobareos:masterfrom
AlexanderS:add-missing-deps
Feb 11, 2025
Merged

debian: Add missing build dependencies#2128
BareosBot merged 2 commits intobareos:masterfrom
AlexanderS:add-missing-deps

Conversation

@AlexanderS
Copy link
Contributor

@AlexanderS AlexanderS commented Jan 21, 2025

The new droplet compatible storage backend introduced in #1790 adds two new dependencies, that were not added to the debian control files. This commit adds the appropriate packages as build dependencies.
Without this cmake will try to load the dependencies by itself and will fail, because git is not available by default during the package build.

Please note: If you are building for bullseye, you will either need a backport of libcli11-dev and libmsgsl-dev or you will need to have git available during the packaging.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

Copy link
Contributor

@florian-at-bareos florian-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AlexanderS, thanks for contributing!
The changes look good! If you'd like to appear in the AUTHORS file, feel free to add your name there and add the change to the pr.

AlexanderS and others added 2 commits February 11, 2025 13:16
The new droplet compatible storage backend introduced in bareos#1790 adds two
new dependencies, that were not added to the debian control files. This
commit adds the appropriate packages as build dependencies. Without this
cmake will try to load the dependencies by itself and will fail, because
git is not available by default during the package build.

Please note: If you are building for bullseye, you will either need a
backport of libcli11-dev and libmsgsl-dev or you will need to have git
available during the packaging.
@BareosBot BareosBot merged commit 10b4bcf into bareos:master Feb 11, 2025
@AlexanderS AlexanderS deleted the add-missing-deps branch February 11, 2025 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants