debian: Add missing build dependencies#2128
Merged
BareosBot merged 2 commits intobareos:masterfrom Feb 11, 2025
Merged
Conversation
b9035b2 to
3fb9e03
Compare
florian-at-bareos
approved these changes
Jan 30, 2025
Contributor
florian-at-bareos
left a comment
There was a problem hiding this comment.
Hey @AlexanderS, thanks for contributing!
The changes look good! If you'd like to appear in the AUTHORS file, feel free to add your name there and add the change to the pr.
7 tasks
The new droplet compatible storage backend introduced in bareos#1790 adds two new dependencies, that were not added to the debian control files. This commit adds the appropriate packages as build dependencies. Without this cmake will try to load the dependencies by itself and will fail, because git is not available by default during the package build. Please note: If you are building for bullseye, you will either need a backport of libcli11-dev and libmsgsl-dev or you will need to have git available during the packaging.
d770364 to
400bba5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new droplet compatible storage backend introduced in #1790 adds two new dependencies, that were not added to the debian control files. This commit adds the appropriate packages as build dependencies.
Without this cmake will try to load the dependencies by itself and will fail, because git is not available by default during the package build.
Please note: If you are building for bullseye, you will either need a backport of libcli11-dev and libmsgsl-dev or you will need to have git available during the packaging.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests