scheduler: 'last' keyword doesn't allow job to be visible in status dir#2120
Merged
BareosBot merged 20 commits intobareos:masterfrom Feb 20, 2025
Merged
scheduler: 'last' keyword doesn't allow job to be visible in status dir#2120BareosBot merged 20 commits intobareos:masterfrom
BareosBot merged 20 commits intobareos:masterfrom
Conversation
697f766 to
302dc35
Compare
sebsura
requested changes
Jan 20, 2025
sebsura
requested changes
Jan 27, 2025
a21c0bc to
f0cff35
Compare
sebsura
requested changes
Feb 3, 2025
sebsura
approved these changes
Feb 13, 2025
cc20bb1 to
4371a57
Compare
sebsura
requested changes
Feb 14, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
There are build failures. Please fix them.
4371a57 to
febf2a9
Compare
Contributor
Author
|
jenkins passed, just fixing one commit message.. |
febf2a9 to
1b5ffac
Compare
sebsura
approved these changes
Feb 20, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Thanks for the great work!
Fixes bareos#2046: scheduler: last keyword doesn't allow job to be visible in status dir The previous implementation of find_next_run has a bug when manually comparing bitfields in DateTimeBitfield, where it does not account for the case where the flag 'last_week_of_month' is set.
in dird, replace RunValidator with DateTime and foreach_run with RunRessource::NextScheduleTime.
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2046: scheduler: 'last' keyword doesn't allow job to be visible in status dir
The previous implementation of find_next_run has a bug when manually
comparing bitfields in DateTimeBitfield, where it does not account for
the case where the flag 'last_week_of_month' is set.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality