bconsole: require only one password in the configuration#2116
Merged
BareosBot merged 8 commits intobareos:masterfrom Jan 23, 2025
Merged
Conversation
sebsura
requested changes
Jan 10, 2025
sebsura
requested changes
Jan 13, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
I noticed some small issues, but apart from these its basically ready for merging
sebsura
approved these changes
Jan 13, 2025
5f4209e to
178aced
Compare
7 tasks
178aced to
d1154f7
Compare
Fixes bareos#2083: bconsole should not require a password in its director configuration. Remove 'required' flag from Password item in Director resource. If no Password item is given, check whether a Console resource is provided and if not abort.
Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
a06873d to
25c0573
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bconsole: director must not always have a password
Fixes #2083: bconsole should not require a password in its director configuration.
Remove 'required' flag from Password item in Director resource. If no
Password item is given, check whether a Console resource is provided
and if not abort.
Add Console resource to bareos-configparser-tests to test changes.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests