bareos-config-libs: double quote dbconfig values#2111
Merged
BareosBot merged 2 commits intobareos:masterfrom Jan 23, 2025
Conversation
sebsura
approved these changes
Jan 21, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
This only breaks if you manually add quotes in the dbconfig prompt. Should we ceck for it ? " may be used in passwords
(This use case was already broken before so this does not change much)
As this is already a great change, ill approve it. Let me know what you think!
This was referenced Jan 22, 2025
b2d13ff to
9467074
Compare
Returned dbconfig values are unquoted. This commit add double quotes around each values (except dbaddress) Unquoted value might create situation where the dbpassword might be truncated by the parser if it contain for example special meaning character like start a comment (`;` or `#`) Fix internal#224 Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
e2bba48 to
03df632
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returned dbconfig values are unquoted. This commit add double quotes
around each values (except dbaddress)
Unquoted value might create situation where the dbpassword might be
truncated by the parser if it contain for example special meaning
character like start a comment (
;or#)Fix bareos/internal#224
Signed-off-by: Bruno Friedmann bruno.friedmann@bareos.com
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality