cmake: add cmake check whether tirpc is installed#2109
Merged
BareosBot merged 10 commits intobareos:masterfrom Jan 20, 2025
Merged
cmake: add cmake check whether tirpc is installed#2109BareosBot merged 10 commits intobareos:masterfrom
BareosBot merged 10 commits intobareos:masterfrom
Conversation
sebsura
requested changes
Jan 8, 2025
sebsura
requested changes
Jan 9, 2025
sebsura
requested changes
Jan 9, 2025
arogge
reviewed
Jan 10, 2025
sebsura
approved these changes
Jan 16, 2025
3066047 to
e413b59
Compare
The problem is that if tirpc is not installed, the cmake runs successfully but the subsequent built fails. Now, the cmake complains that it misses the tirpc package and fails.
Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
Note that for some linux distros and versions the tirpc library is already included in libc and its headers can be found in /usr/include/rpc whereas for others tirpc is a standalone package where its headers can be found in /usr/include/tirpc/rpc.
aa90ad9 to
46dd749
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that if tirpc is not installed, the cmake runs successfully but the subsequent built fails. Now, the cmake complains that it misses the tirpc package and fails.
Thank you for contributing to the Bareos Project!
Please check
Your name is present in the AUTHORS file (optional)If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality