Inherit RunScript elements between JobDef resources#2097
Merged
BareosBot merged 3 commits intobareos:masterfrom Feb 3, 2025
Merged
Inherit RunScript elements between JobDef resources#2097BareosBot merged 3 commits intobareos:masterfrom
BareosBot merged 3 commits intobareos:masterfrom
Conversation
Contributor
|
Do you want to add yourself to the authors file ? |
sebsura
requested changes
Jan 7, 2025
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Could also you update the copyright date in this file ?
I would also like to have some kind of test for this.
Either a simple systemtest that where you can check the successful inheritance in the joblog (see examples in systemtests/tests) or a unit test like addresses_and_ports_config.cc (in core/src/tests).
You can load a config in a unit test by using DirectorPrepareResources.
You can then use GetResWithName to get the jobdef resource and check if it sucessfully inherited the runscript from a different jobdef.
Let me know if you need help for this.
876bfd8 to
e14b987
Compare
sebsura
approved these changes
Jan 27, 2025
This change allows RunScript elements to be inherited between JobDef resources in the same way that they are inherited to Job resources from JobDef resources. See the discussion at bareos#2013
deb69f6 to
d758d2f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change allows RunScript elements to be inherited between JobDef resources in the same way that they are inherited to Job resources from JobDef resources.
See the discussion at
#2013
Thank you for contributing to the Bareos Project!
Please check
Your name is present in the AUTHORS file (optional)If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality
Tests