Skip to content

Sync EvpDigest between OpenSSL <1.1 and 1.1+#2087

Merged
pstorz merged 1 commit intobareos:bareos-24from
pstorz:backport/bareos-24/openssl-1.0-EvpDigest
Dec 22, 2024
Merged

Sync EvpDigest between OpenSSL <1.1 and 1.1+#2087
pstorz merged 1 commit intobareos:bareos-24from
pstorz:backport/bareos-24/openssl-1.0-EvpDigest

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Dec 21, 2024

Backport of PR #2086 to bareos-24

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Correct milestone is set
Source code quality (if there were changes to the original PR)
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

Backport quality

Commit PR bareos#1689 (812f9e4) contains a
change in core/src/lib/crypto.h, which has only been partially synced
with core/src/lib/crypto_openssl.cc. The latter file contains two
definitions of EvpDigest(), depending on OpenSSL major version. Only one
was fixed.

When compiling e.g. on CentOS 7 one gets an error about shadowing.

(cherry picked from commit a85a409)
@pstorz pstorz force-pushed the backport/bareos-24/openssl-1.0-EvpDigest branch from 375340f to 6468395 Compare December 21, 2024 16:01
@pstorz pstorz self-assigned this Dec 21, 2024
@pstorz pstorz added this to the 24.0.1 milestone Dec 21, 2024
@pstorz pstorz merged commit a2e4f6e into bareos:bareos-24 Dec 22, 2024
@pstorz pstorz deleted the backport/bareos-24/openssl-1.0-EvpDigest branch December 22, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants