You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When the vmware plugin recreates a VM it checks all MAC addresses to avoid a conflict.
If a cloning (or maybe also migration) task is in progress, the destination VM does not have a config yet and the following error occurs:
2024-11-20 15:53:18.874 | DEBUG | bareos-fd-vmware:check_mac_address:3131 - !!! vm: 'vim.VirtualMachine:vm-233350'
2024-11-20 15:53:18.878 | DEBUG | bareos-fd-vmware:check_mac_address:3132 - !!! vm.config: None
bareos-disk-sd-int-fr2.storage.xxxx.xxxx.xx (150): include/python_plugins_common.inc:125-30 bareosfd: Traceback (most recent call last):
File "/usr/lib/bareos/plugins/BareosFdWrapper.py", line 59, in handle_plugin_event
return bareos_fd_plugin_object.handle_plugin_event(event)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/bareos/plugins/bareos-fd-vmware.py", line 1076, in handle_plugin_event
return self.start_restore_job()
^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/bareos/plugins/bareos-fd-vmware.py", line 618, in start_restore_job
return self.vadp.prepare_vm_restore()
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/lib/bareos/plugins/bareos-fd-vmware.py", line 1549, in prepare_vm_restore
if not self.create_vm():
^^^^^^^^^^^^^^^
File "/usr/lib/bareos/plugins/bareos-fd-vmware.py", line 1883, in create_vm
self.check_mac_address(config_info)
File "/usr/lib/bareos/plugins/bareos-fd-vmware.py", line 3133, in check_mac_address
for dev in vm.config.hardware.device:
^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'hardware'
swenske
changed the title
VMware plugin: fix check_mac_address()
VMware plugin: fix check_mac_address() for vm.config not present
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sduehr
left a comment
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality