Skip to content

mssql TearDownVdiDevice(): enhance error reporting#2008

Merged
BareosBot merged 2 commits intobareos:masterfrom
pstorz:dev/pstorz/master/mssql-teardown-error-reporting
Dec 2, 2024
Merged

mssql TearDownVdiDevice(): enhance error reporting#2008
BareosBot merged 2 commits intobareos:masterfrom
pstorz:dev/pstorz/master/mssql-teardown-error-reporting

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Nov 8, 2024

Thank you for contributing to the Bareos Project!

TearDownVdiDevice() only has a limited error reporting when VDIDevice->GetCommand() fails.
This PR now prints the actual Value of the result.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
    Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@sebsura sebsura added this to the 24.0.0 milestone Dec 2, 2024
@sebsura sebsura force-pushed the dev/pstorz/master/mssql-teardown-error-reporting branch from 070a96e to e9878f9 Compare December 2, 2024 07:20
@BareosBot BareosBot force-pushed the dev/pstorz/master/mssql-teardown-error-reporting branch from 5a143ce to 7125d2a Compare December 2, 2024 09:04
@BareosBot BareosBot merged commit cd9393b into bareos:master Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants