Skip to content

add Honor No Dump Flag to config output#1994

Merged
BareosBot merged 3 commits intobareos:masterfrom
arogge:fix-show-fileset
Nov 8, 2024
Merged

add Honor No Dump Flag to config output#1994
BareosBot merged 3 commits intobareos:masterfrom
arogge:fix-show-fileset

Conversation

@arogge
Copy link
Member

@arogge arogge commented Oct 28, 2024

this adds support for fileset option "Honor No Dump Flag" when printing the configuration. Previously this option would never show up and yield an error when printing the configuration.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@arogge arogge self-assigned this Oct 28, 2024
this adds support for fileset option "Honor No Dump Flag" when printing
the configuration. Previously this option would never show up and yield
an error when printing the configuration.
Copy link
Contributor

@sebsura sebsura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sebsura sebsura added this to the 25.0.0 milestone Nov 7, 2024
@BareosBot BareosBot merged commit 2eeb3b5 into bareos:master Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug This addresses a bug requires backport to 23

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants