stored: fix volume size mismatch#1992
Merged
BareosBot merged 3 commits intobareos:masterfrom Nov 6, 2024
Merged
Conversation
arogge
approved these changes
Nov 6, 2024
We currently overwrite the current volume info on the device with the outdated volume info from the director (which has size = 0) before "updating" the volume info on the director. This causes the volume size mismatch now that we do not have the pre_label split anymore (previously we would execute RewriteVolumeLabel before writing to the device which would have fixed this issue). As a quick fix we can just disable this overwriting and just send the real info to the director immediately.
Our python version hex was not correct for numbers >= 10. We previously emitted e.g. 0x03100000 for 3.10, when its supposed to be 0x030A0000. This was causing weird crashes because workarounds for old versions that were not supposed to be enabled for newer versions were in fact enabled.
1f99e48 to
9862c25
Compare
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently overwrite the current volume info on the device with the outdated volume info from the director (which has size = 0) before "updating" the volume info on the director. This causes the volume size mismatch now that we do not have the pre_label split anymore (previously we would execute RewriteVolumeLabel before writing to the device which would have fixed this issue).
As a quick fix we can just disable this overwriting and just send the real info to the director immediately.
This PR also fixes an issue with the python plugin, where we did not correctly compare versions, which lead to weird behaviour.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality