docs: improve debuginfo install description (fix issue #1943)#1980
Merged
BareosBot merged 2 commits intobareos:masterfrom Oct 22, 2024
Merged
Conversation
59f8561 to
44d4b99
Compare
44d4b99 to
b0cf018
Compare
sebsura
requested changes
Oct 17, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
The changes are great. I added some comments to the documentation that you added.
778867e to
33d5e22
Compare
Contributor
Author
|
@sebsura as discussed, I've redone the section, by putting in first place how to install all, then only describe specific daemon with fd as an example. |
sebsura
requested changes
Oct 18, 2024
33d5e22 to
2e84ad7
Compare
2e84ad7 to
8db7af3
Compare
sebsura
approved these changes
Oct 22, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Great changes. Thanks for your work!
This was referenced Oct 22, 2024
Contributor
Author
|
Backport created now last build for merge |
Fix issue bareos#1943 Explain first how to install all, then add a note how-to do so for only Bareos Filedaemon. Additionnaly explain how to allow ptrace operations. Cleanup trailing new line Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> Co-authored-by: Sebastian Sura <124262655+sebsura@users.noreply.github.com>
8db7af3 to
12fcc59
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue docs: update debuginfo-install documentation #1943
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General