Disable writing PRE_LABEL label-type to support WORM media#1958
Merged
BareosBot merged 6 commits intobareos:masterfrom Oct 11, 2024
Merged
Disable writing PRE_LABEL label-type to support WORM media#1958BareosBot merged 6 commits intobareos:masterfrom
BareosBot merged 6 commits intobareos:masterfrom
Conversation
b054723 to
b20849d
Compare
pstorz
requested changes
Sep 17, 2024
Member
pstorz
left a comment
There was a problem hiding this comment.
The code looks good. Maybe we want to document somewhere that we now support WORM tapes and for that no PRE_LABELS are ever written now?
pstorz
approved these changes
Oct 11, 2024
7 tasks
instead of writing a pre-label to an empty volume when labeling it, we write the real volume-label right away so we don't have to rewrite it when we actually start writing to the volume. This will allow using WORM storages.
the VolFiles was previously fixed to 0 for new volumes, however when not using pre-labels, the label will fill file 0, so VolFiles should be 1. To achieve this, the `3000 OK label` message was slightly extended.
with the changed `3000 OK label` message this tests requires a slight change.
as the first write to a volume will no longer overwrite the volume-label, instead of pre-labeling a volume for this test we rely on auto-labeling so the bSdEventLabelWrite event will be triggered.
When mounting a volume that contains a VOL_LABEL, the SD would log the following message: Volume "XXX" previously written, moving to end of data. As that could be misleading now that newly labeled volumes will contain a VOL_LABEL and the message would appear for volumes that only habe a label, but no data.
b20849d to
5e09eda
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change disables the use of PRE_LABEL label-type when labeling volumes without writing data to them.
Instead a normal volume label is written and the label will not be overwritten when the volume appended to afterwards.
With this change append-only media can now be used.
Resolves #1781
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests