Skip to content

console.cc: forbid @exec etc. as privileged user#1950

Merged
BareosBot merged 15 commits intobareos:masterfrom
pstorz:dev/pstorz/master/confine-bconsole-@-commands
Oct 3, 2024
Merged

console.cc: forbid @exec etc. as privileged user#1950
BareosBot merged 15 commits intobareos:masterfrom
pstorz:dev/pstorz/master/confine-bconsole-@-commands

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Sep 5, 2024

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@joergsteffens joergsteffens added this to the 24.0.0 milestone Sep 23, 2024
Copy link
Member

@joergsteffens joergsteffens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, I approve this PR. I added some keywords as documentation. Please check, if these are okay by you.
Lets see, if the tests still run through.
Before merging, please squash the commits.

@joergsteffens
Copy link
Member

To not break existing scripts, I assume that backports are not planned, correct?

@joergsteffens joergsteffens force-pushed the dev/pstorz/master/confine-bconsole-@-commands branch from 638959f to 5f64a36 Compare September 23, 2024 16:15
@pstorz pstorz force-pushed the dev/pstorz/master/confine-bconsole-@-commands branch from 97a16bc to 330aafd Compare September 30, 2024 09:52
@pstorz pstorz force-pushed the dev/pstorz/master/confine-bconsole-@-commands branch from 226e874 to 4a7cf14 Compare October 2, 2024 14:59
@BareosBot BareosBot merged commit 3f0b3a0 into bareos:master Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants