console.cc: forbid @exec etc. as privileged user#1950
Merged
BareosBot merged 15 commits intobareos:masterfrom Oct 3, 2024
Merged
console.cc: forbid @exec etc. as privileged user#1950BareosBot merged 15 commits intobareos:masterfrom
BareosBot merged 15 commits intobareos:masterfrom
Conversation
joergsteffens
approved these changes
Sep 23, 2024
Member
joergsteffens
left a comment
There was a problem hiding this comment.
Generally, I approve this PR. I added some keywords as documentation. Please check, if these are okay by you.
Lets see, if the tests still run through.
Before merging, please squash the commits.
Member
|
To not break existing scripts, I assume that backports are not planned, correct? |
638959f to
5f64a36
Compare
97a16bc to
330aafd
Compare
Also allow to set test-specific environment vars via enviornment.local file
226e874 to
4a7cf14
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality
Tests