systemtests: fix plugin postgresql testrunner-*#1947
Merged
BareosBot merged 5 commits intobareos:masterfrom Sep 24, 2024
Merged
Conversation
16 tasks
478938d to
273d486
Compare
Member
|
As I started reviewing #1948, I continued on it. After that is finished, we can continue here. (if this is more convenient, we can also reverse the order). |
Contributor
Author
joergsteffens
approved these changes
Sep 23, 2024
- commit 475b131 was needed to extract the correct major version it was reworked to use `pg_lsclusters` to detect server version instead `psql` tool version. - if installed postgresql is lower than major 10 the tests is marked as skipped. - the `pg_*cluster` commands need to be run as root user. the systemtest will now check that condition and mark the test as `skipped` if not. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
fix all testrunner (except debian) - move redondant code for PG_VERSION to `setup_local_db.sh` - move redondant check PG_VERSION > 10 to `setup_local_db.sh` - add --no-psqlrc flag to PGSQL command Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
For testrunner-debian, we want to pick up the highest available major version pg_lsclusters will handle (mostly main cluster).
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
588a3ae to
a3c2ae7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it was reworked to use
pg_lsclustersto detect server versioninstead
psqltool version.marked as skipped.
pg_*clustercommands need to be run as root user.the systemtest will now check that condition and mark the test
as
skippedif not.setup_local_db.shsetup_local_db.shThank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests