docs: add ADR infrastructure and first ADRs#1945
Merged
BareosBot merged 3 commits intobareos:masterfrom Sep 12, 2024
Merged
Conversation
25593a9 to
ad511f6
Compare
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Great work, and improvement to the project ...
Can you check my comment about .adr-dir ?
Contributor
|
I believe we should introduce ADR into the documentation. But that maybe into a second stage. |
bruno-at-bareos
requested changes
Sep 3, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
As discussed and not forget : a note need to be added to documentation mentioning the fact that we are using ADR now.
It is certainly more devoted to devs, but may have an general interest for users to followup changes?
bruno-at-bareos
approved these changes
Sep 12, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks a lot for the documentation addition. This PR is now ready for merge
1483327 to
60d7c7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As the title sais. Add ADR directory, template and a readme that describes the process.
Also add ADRs for
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality