webui: properly set focus to input box after each command#1936
webui: properly set focus to input box after each command#1936BareosBot merged 3 commits intobareos:masterfrom
Conversation
Focusing scrolling should come after ajax returns.
joergsteffens
left a comment
There was a problem hiding this comment.
@Tydus Thank you very much for your very helpful contribution. I also added a tiny adjustment, so that it also works when just typing Enter. If you like, you can add your (real) name to the AUTHORS file. Otherwise I'll merge it in the next days.
|
Thanks for your timely reply! It's just a humble tiny patch so I'd like to defer that for more contribution 🤗 BTW (sorry for OT) I'm now looking into the fd code. We are starting to have some parallelism from #1533 , but isn't it even better to have multiple files to be read/processed simultaneously? FS with tons of small files would benefit a lot. |
In general, parallelism per file would be better, however, the code introduced in #1533 already improved performance a lot and did require much less changes than a full parallelism would have. What makes parallelism hard is that the Storage Daemon don't generally have a random access backup, but have to write sequential (to keep compatibility with e.g. tape drives, access other back-ends like disks is handled the same), So blocks of files in random order would cause problems, or you've to use in-memory caches on the FD or SD, which also causes problems. |
The console of webui, among others, could not have the input box focused after issuing each command.
This patch is to fix this tiny but annoying UX issue. It also fixes the scrolling.
Thank you for contributing to the Bareos Project!
Please check
Your name is present in the AUTHORS file (optional)If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality