webui: fix handling deleted clients in restore browser#1933
Merged
BareosBot merged 21 commits intobareos:masterfrom Sep 26, 2024
Merged
webui: fix handling deleted clients in restore browser#1933BareosBot merged 21 commits intobareos:masterfrom
BareosBot merged 21 commits intobareos:masterfrom
Conversation
15 tasks
33abf3e to
d9769aa
Compare
cfc1dc2 to
ec486c7
Compare
sebsura
requested changes
Aug 27, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
There are some very good changes in here. I only looked at the changes in core for now but i already have some comments.
sebsura
requested changes
Aug 29, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
I still need to look at some php files but as it might take some time i wanted to already give you some feedback.
sebsura
requested changes
Sep 2, 2024
A joblevel at the "run" command must be specified as Full, Differential or Incremental, while the job level at the list command must be specified as F, D or I. This change allows the the job level atthe list command can also be used by its full names. (cherry picked from commit 8c1cbfb)
The python-bareos systemtests do test a lot of functionality. As every test must be able to run indepently and in random order, the tests often ensured that test data is available by running a backup job. This change uses the recently introduced function get_backup_jobid to ensure the availability of test data in a more efficient way: if a job with the requested parameter already exists, it's jobid is returned. Otherwise the requested job is started. (cherry picked from commit e5b38b3)
... as the code for both has been nearly identical.
552f04f to
585ef8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
See #1851
This change allows to restore files from clients no longer part of Bareos to other clients.
This did require changes to core as well as webui.
Also some systemtests has been added to test the parameter handling of the bconsole commands.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality
Tests