python-bareos: fix backslash usage in regex#1917
Merged
BareosBot merged 2 commits intobareos:masterfrom Aug 14, 2024
Merged
Conversation
Contributor
|
I suppose syntaxwarning instead systax right ? maybe worse fixing the typo in commit and pr title |
bbfceb9 to
f37018e
Compare
This was referenced Aug 14, 2024
We used "\d" in a Python regex, which is ambiguous and is considered invalid in newer Python versions: Python >= 3.8 will issue a DeprecationWarning, Python >= 3.12 a SyntaxWarning and later version will issue a SyntaxError. Therefore we adapted it to the unambiguous "\\d" sequence.
c4c9758 to
0d1d45c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used "\d" in a Python regex,
which is ambiguous
and is considered invalid in newer Python versions:
Python >= 3.8 will issue a DeprecationWarning,
Python >= 3.12 a SyntaxWarning
and later version will issue a SyntaxError.
Therefore we adapted it to the unambiguous "\d" sequence.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality