Skip to content

nsi installers: remove postgresql backend#1914

Merged
BareosBot merged 14 commits intobareos:masterfrom
pstorz:dev/pstorz/master/windows-installer-mandatory-posgtgresql-backend
Sep 12, 2024
Merged

nsi installers: remove postgresql backend#1914
BareosBot merged 14 commits intobareos:masterfrom
pstorz:dev/pstorz/master/windows-installer-mandatory-posgtgresql-backend

Conversation

@pstorz
Copy link
Member

@pstorz pstorz commented Aug 5, 2024

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
  • Correct milestone is set
  • Merged ci-scripts branch PR-1914 into master
  • The WebUI works after full install
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
Tests
  • On a fail, output of the test leads quickly to the origin of the fault

@sebsura sebsura linked an issue Aug 13, 2024 that may be closed by this pull request
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once installed there's an error on bconsole and all services are not registered
with the native build.

bconsole_after_installation

@bruno-at-bareos
Copy link
Contributor

trying the dir daemon also show a problem with the libpq.dll not found
here PG 16.3 is installed.

bareos-dir_libpq_missing

Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • The connection to the database is now okay.
  • As discussed we certainly want to have bareos password fields as text (easier especially for new comers to export fd to dir)
  • I've detected a minor trouble, when you change the installer to minimal in fact it select everything (Native & winbareos), we should fix that.
    install_standard_initial
    install_minimal_selection
    Is this due to the fact that minimal is after Full ?

@bruno-at-bareos bruno-at-bareos self-requested a review September 5, 2024 08:27
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While the password and section seems to all works as expected, Bareos Native director is failing to start, not able to find the libpq.dll and its related libint-9.dll

winbareos works well ?

@bruno-at-bareos bruno-at-bareos self-requested a review September 11, 2024 09:10
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A final test on both version was fully functional.
Thanks for the great work.

I would go a bit of squashing to clean up the git history (+ reset matrix).
I will let open one checkbox so the merge will not be automatic.

@pstorz pstorz force-pushed the dev/pstorz/master/windows-installer-mandatory-posgtgresql-backend branch from 35f6310 to 59c2dd0 Compare September 11, 2024 13:44
@bruno-at-bareos
Copy link
Contributor

bruno-at-bareos commented Sep 12, 2024

Webui works after testing with version Bareos-24.0.0~pre1105.c083f9e03-x64-Release.exe

@pstorz pstorz force-pushed the dev/pstorz/master/windows-installer-mandatory-posgtgresql-backend branch from 145ccbf to 20f0dc7 Compare September 12, 2024 15:04
@BareosBot BareosBot force-pushed the dev/pstorz/master/windows-installer-mandatory-posgtgresql-backend branch from 659919c to f9e9d89 Compare September 12, 2024 16:04
@BareosBot BareosBot merged commit 4358430 into bareos:master Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

remove PostgreSQL backend option from Windows Installer

3 participants