cats: scripts add option --no-psqlrc to psql#1900
Merged
BareosBot merged 3 commits intobareos:masterfrom Aug 7, 2024
Merged
Conversation
--if-exists is supported since a decade introduced with PostgreSQL 9.2 Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com> (cherry picked from commit d75dcf4)
While it is rare to have .psqlrc configuration file setup for user like `bareos` or `postgres`, it may contains configuration that may defeat our expectation in terms of return. `--no-psqlrc` is now added to all catalog scripts. Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
3f01bef to
92916c8
Compare
This was referenced Aug 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
script: add --if-exists to dropdb
This commit will turn the error into a warning when we try to dropdb
non existing database.
cats: add option --no-psqlrc to psql command in scripts
While it is rare to have .psqlrc configuration file setup for user
like
bareosorpostgres, it can contains configuration thatmay defeat our expectation in terms of return.
--no-psqlrcis now added to all catalog scripts.Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality