Merged
Conversation
Member
|
I want this! :) |
arogge
approved these changes
Jul 9, 2024
Contributor
Author
So it mean I just got a green light to update my CD-Buildimage branch to make ready of 156 :-) |
fe31114 to
4fee5a6
Compare
89fca53 to
88beb2b
Compare
d75dcf4 to
e8da991
Compare
This was referenced Jul 30, 2024
sebsura
requested changes
Jul 31, 2024
FreeBSD's awk unlike gawk does not have gensub(), now match() and substr() is used instead. - systemtests: Fix mtx-changer test on FreeBSD The scripts used /bin/true, but that doesn't exist on FreeBSD any more. Now using /usr/bin/env true, that should work on all systems.
- replace shutdown_mysql_server by calling mysql_cleanup in case of startup error - function improve code by quoting variables - adjust copyright year Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- set sle156 as new default Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- remove generated configuration commited by error
Avoid failure on loaded hosts Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
suse156 has a newer glibc 2.38.
800ced6 to
ba96c62
Compare
This is in preparation of removing `create_unique_socket_number()`. As these configuration values are not currently used in the tests, it makes sense to just set them to 0 for now.
(socket-) fds are allowed to be zero, so we should instead be checking for '< 0' to detect bad socket fds.
(socket-) fds are allowed to be zero, so we should instead be checking for '< 0' to detect bad socket fds.
We were always trying to find an unused port, and then we try to bind that port. This is not a good way to do it as there is no guarantee that the port will still be free when we actually try to bind the port, especially if there are a lot of concurrent tests running. Now we do it the opposite way: First we bind a random os-provided free port and only then do we find out which port it actually is. That should make sure that no two unit tests should ever try to bind the same port. There may still be conflicts between unittest ports and system test ports, but that can be fixed in a different way (e.g. just do not run that at the same time).
If we do not wait long enough, then the number of `send()`s changes.
e70d8e8 to
1fc1a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality