webui: fixing selenium tests#1885
Merged
BareosBot merged 12 commits intobareos:masterfrom Aug 12, 2024
Merged
Conversation
sebsura
requested changes
Jul 30, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
For me all tests fail with
Traceback (most recent call last):
File "/home/ssura/Projekte/bareos/webui/tests/selenium/webui-selenium-test.py", line 189, in setUp
self.driver = webdriver.Chrome(
^^^^^^^^^^^^^^^^^
TypeError: WebDriver.__init__() got an unexpected keyword argument 'service'
Contributor
|
Looks like Selenium 4.0+ is required now |
Contributor
|
Testing with venv + Selenium 4.0+ seems to make the test pass |
0ca936f to
f196d10
Compare
Member
Author
Instead of adapting all the repotest images to selenium >= 4 (not sure, if this is possible), I made it work with selenium 3 and 4. |
sebsura
requested changes
Aug 8, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
The testrunner.in -> testrunner rename broke a lot of things as the testrunner still uses cmake-variables.
Also the configure_file command for that file was never removed, so cmake errors out during the configuration step.
d9b4adb to
f6df2c4
Compare
Member
Author
|
jenkins ended successfully. |
Removed array_key_exists, as it fails when parameter is not an valid array. However, empty especially !empty alone gies us the wanted results.
173d2bb to
4c07acb
Compare
7 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During testing I found out, that selenium tests seem to be outdated.
I adapted them to use them a least locally.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality