docs: improve Restoring a Bareos Server section#1878
docs: improve Restoring a Bareos Server section#1878BareosBot merged 2 commits intobareos:masterfrom
Conversation
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks for your suggestion, I've a slightly different fix you may want to apply.
|
Also now the build doc has tried there's some failures you want to fix |
|
Thanks for the hints! |
|
Reopened, fixes will goes there as all the other parameters are already in place. (tagging project labels etc) |
|
To change your commit you may simply want to rebase and adjust the changes. So in your clone, be sure you have a fresh master (git switch master && git pull) then back to your branch you can Use the reword and edit to apply your changes then you should be able to git push --force your branch |
|
We are working on a way to allow external contributor to have access to build result, I will take care of the message after your submission. |
|
We have this section into the documentation that may help For example your commit to the rst can have as subject With a body like So the subject is short enough (around 50 char) but explicit for the changelog. Once you have it done, you should also modify the title pr here so it can be also used during the merge. |
4a178fd to
b240112
Compare
|
I think I managed to change it properly. Thanks for all the tips, I already learned a lot more about git! |
|
Build still failing :/ |
No in fact, the final review is now needed (which I will take care of today). |
And I will fix the warning of our pr-tool If you want to contribute more, it will be interesting to setup a dev environment (see documentation it should be complete), you will find our tools in the devtools subdir. |
- add example how to load the restored database ascii dump as catalog - update the AUTHORS file.
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks for the work, Approved.
|
Thanks for the help! |
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality