Merged
Conversation
9a6de22 to
c3cf075
Compare
sebsura
reviewed
Jul 5, 2024
sebsura
reviewed
Jul 8, 2024
sebsura
requested changes
Jul 9, 2024
* use std::mutex * use destructor instead of manual teardown * disable move/copy
without this patch a new configuration resource would also create a new runtime status. This lead to all sorts of issues. Including, but not limited to, wrong bookkeeping of concurrent jobs. Instead of creating a new runtime status, we now pick an existing one for the resource with the same name and only create a new one if we do not have a status yet.
d21622b to
1f9765c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On a reload, resources (Job, Client and Storage) will get new runtime status objects. As those are used to track concurrent jobs and related things, this leads to all kinds of strange behaviours.
This PR registers the status objects by resource name, so on a reload a resource with the same name will get the same status object.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests