NDMP_NATIVE: enable full restore, eject tape before unload, enable update of NDMP environment#1862
Merged
BareosBot merged 11 commits intobareos:masterfrom Dec 10, 2024
Merged
Conversation
1ef3e3c to
4083cd4
Compare
b2fa79a to
349e92f
Compare
b462563 to
ab6ce38
Compare
a6a3ead to
603e2ad
Compare
50fcf00 to
e25f3a2
Compare
e25f3a2 to
a33d56b
Compare
Merged
7 tasks
sebsura
requested changes
Dec 9, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Another thing i found:
// FIXME: disabled because of "missing media entry" error
// if (!ndmp_validate_job(jcr, &ndmp_sess.control_acb->job)) {
// goto cleanup;
//}
once testing is setup, we need to check why this is commented out. It reads like its important ...
arogge
reviewed
Dec 9, 2024
2b069a2 to
54ade31
Compare
sebsura
approved these changes
Dec 9, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
We just need to squash the commits once we know that the rebase did not mess anything up.
54ade31 to
3bbbe09
Compare
3bbbe09 to
c7c626b
Compare
c7c626b to
8fad785
Compare
Allow the update of NDMP Environment Values by handling errors like: ERROR: duplicate key value violates unique constraint "ndmpjobenvironment_pkey" DETAIL: Key (jobid, fileindex, envname)=(5, 1, HIST) already exists.
During an NDMP Backup, the current status was logged every 30 seconds. We now make the interval 300 seconds so that the logfile is not filled so much.
8fad785 to
b32b7a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR enhances the handling of NDMP NATIVE Backups
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality