Merged
Conversation
arogge
requested changes
Jul 1, 2024
Member
arogge
left a comment
There was a problem hiding this comment.
I might have a slightly nicer approach, what do you think?
6b90ef9 to
16aa75a
Compare
Contributor
Author
|
Added the changes you suggested. |
arogge
approved these changes
Jul 25, 2024
16aa75a to
2df077c
Compare
We called a function that locks the jcr while we a already held the lock, which causes a deadlock. This commit fixes this by offering an alternative function which does no locking.
The label prevented reruns from working
9aa266f to
0422a72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We called a function that locks the jcr while we a already held the lock, which causes a deadlock. This commit fixes this by offering an alternative function which does no locking.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality