dir: fix crash on purge with job without client#1857
Merged
BareosBot merged 2 commits intobareos:masterfrom Jul 8, 2024
Merged
dir: fix crash on purge with job without client#1857BareosBot merged 2 commits intobareos:masterfrom
BareosBot merged 2 commits intobareos:masterfrom
Conversation
sebsura
approved these changes
Jun 17, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Looks good to me. I would definitely also backport this to 22. Should we do 21 as well ?
6 tasks
dfbc05d to
ffb8e20
Compare
Contributor
|
Just fixed the commit log message length to make pr-tool happy |
purge volume would crash if the first job declared in your configuration has no client defined, because the code uses the default-client taken from there to fill information in the log messages. That not really required information has been removed from the log messages which will also fix the crash.
ffb8e20 to
ad72803
Compare
Contributor
|
Rebased on master so that this can get merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
purge volume would crash if the first job declared in your configuration has no client defined, because the code uses the default-client taken from there to fill information in the log messages.
That not really required information has been removed from the log messages which will also fix the crash.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality