Merged
Conversation
arogge
reviewed
Jun 11, 2024
arogge
requested changes
Jun 21, 2024
Member
arogge
left a comment
There was a problem hiding this comment.
This seems to work pretty well so far. Thank you!
There are three things that should be addressed before we can merge this pull request.
rename the header to vss_client.h
calling it vss_client.h would align its name with its content, which is mainly class VssClient.
fix include guard in header
the include guard (for the renamed header) should be BAREOS_WIN32_INCLUDE_VSS_CLIENT_H_
update copyright years in changed files
the copyright header of the files you changed still states the latest update was 2023. Even for minor changes the year needs to be updated.
sebsura
approved these changes
Jul 1, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks for your work!
arogge
approved these changes
Jul 1, 2024
Co-authored-by: Andreas Rogge <andreas.rogge@bareos.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #1843
Please check
Your name is present in the AUTHORS file (optional)If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality