Skip to content

Fix mistake in VolumeManagement.rst#1829

Merged
BareosBot merged 2 commits intobareos:masterfrom
Gankov:patch-1
May 28, 2024
Merged

Fix mistake in VolumeManagement.rst#1829
BareosBot merged 2 commits intobareos:masterfrom
Gankov:patch-1

Conversation

@Gankov
Copy link
Contributor

@Gankov Gankov commented May 27, 2024 •
edited by bruno-at-bareos
Loading

I think Media Type must be equal in Director and Storage Configuration.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@Gankov
Fix mistake in VolumeManagement.rst
3a1ee73 
I think Media Type must be equal in Director and Storage Configuration.
@bruno-at-bareos
Copy link
Contributor

bruno-at-bareos commented May 27, 2024

I don't know why you think so

Storage {
  Name = FileStorage
  Address = bareos-sd.example.com
  Password = local_storage_password
  Device = RecycleDir
  **Media Type = File**
}

Storage {
  Name = FileStorage2
  Address = bareos-sd.example.com
  Password = local_storage_password
  Device = RecycleDir2
  **Media Type = File1**
}

@bruno-at-bareos bruno-at-bareos added the documentation This PR changes only documentation label May 27, 2024
@Gankov
Copy link
Contributor Author

Gankov commented May 27, 2024

May be I am mistaken. But in the documentation https://docs.bareos.org/Configuration/Director.html#config-Dir_Storage_MediaType it is written:

The MediaType specified in the Director’s Storage resource must correspond to the Media Type specified in the Device resource of the Storage daemon configuration file.

For the example «Example for two clients, separate devices and recycling», the director config had File1 media type

bareos/docs/manuals/source/TasksAndConcepts/VolumeManagement.rst

Line 276 in 93eccb2

Media Type = File1
.

But in storage config had File2 media type

bareos/docs/manuals/source/TasksAndConcepts/VolumeManagement.rst

Line 338 in 93eccb2

Media Type = File2
.

Is it not a mistake?

@bruno-at-bareos
Copy link
Contributor

bruno-at-bareos commented May 27, 2024

Is it not a mistake?

No you're right, nice catch. :-)

@arogge arogge requested a review from bruno-at-bareos May 28, 2024 10:11
bruno-at-bareos
bruno-at-bareos approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@bruno-at-bareos bruno-at-bareos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good Catch ! Thanks for the fix.

@bruno-at-bareos bruno-at-bareos mentioned this pull request May 28, 2024
Merged
6 tasks
@BareosBot BareosBot merged commit 1647300 into bareos:master May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-at-bareos bruno-at-bareos bruno-at-bareos approved these changes

Assignees

@bruno-at-bareos bruno-at-bareos

Labels

documentation This PR changes only documentation requires backport to 23

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Gankov @bruno-at-bareos @BareosBot