ULC: build the universal linux client also for rpm based OS.#1824
Merged
BareosBot merged 24 commits intobareos:masterfrom Jul 23, 2024
Merged
ULC: build the universal linux client also for rpm based OS.#1824BareosBot merged 24 commits intobareos:masterfrom
BareosBot merged 24 commits intobareos:masterfrom
Conversation
33d2195 to
678c4fa
Compare
930aff9 to
c77727c
Compare
arogge
reviewed
Jun 3, 2024
7cfb674 to
aa56690
Compare
arogge
requested changes
Jun 20, 2024
Member
arogge
left a comment
There was a problem hiding this comment.
we need to address a few things in the spec to make it work cross-distro (i.e. on SUSE and maybe others, too)
Comment on lines
+165
to
+169
| %if 0%{?suse_version} | ||
| Requires(pre): shadow | ||
| %else | ||
| Requires(pre): shadow-utils | ||
| %endif |
Member
There was a problem hiding this comment.
we cannot have distro-dependant Requires in the ULC package
3c96a1b to
2ae6e33
Compare
49550e4 to
312b40b
Compare
bbc8021 to
051bcbd
Compare
the build-rpm.sh doesn't produce source rpms
051bcbd to
756fc6d
Compare
arogge
approved these changes
Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.Special
General
Source code quality