build: enable building for Fedora40 and Ubuntu 24.04#1815
Merged
BareosBot merged 26 commits intobareos:masterfrom Jul 22, 2024
Merged
build: enable building for Fedora40 and Ubuntu 24.04#1815BareosBot merged 26 commits intobareos:masterfrom
BareosBot merged 26 commits intobareos:masterfrom
Conversation
This was
linked to
issues
May 16, 2024
Closed
1957240 to
6f21422
Compare
354bf6b to
197747a
Compare
arogge
requested changes
Jun 6, 2024
Member
arogge
left a comment
There was a problem hiding this comment.
I have a few remarks concerning the CPM integration. But overall this looks good!
arogge
requested changes
Jun 18, 2024
Member
arogge
left a comment
There was a problem hiding this comment.
move CPMAddPackage() calls into its own file and include in top-level CMakeLists.txt
Member
|
Relates to #1850 |
0c2622f to
6170046
Compare
2b85dee to
58c595e
Compare
e181e3a to
012eb66
Compare
012eb66 to
356395a
Compare
Co-authored-by: Andreas Rogge <andreas.rogge@bareos.com>
All packages handled by CPM should be moved here. Also searches for PS as before, but sets it as REQUIRD for the systemtests.
as the file declares the CPM packages that Bareos is going to use, this should make things a bit easier to find.
just to make sure everything is built with PIC enabled, we move the flag to the very top of CMakeLists.txt
* allow disabling of CPM_USE_LOCAL_PACKAGES * improve warning message for FETCHCONTENT_FULLY_DISCONNECTED * silence warning if both FETCHCONTENT_FULLY_DISCONNECTED and CPM_LOCAL_PACKAGES_ONLY is set
This reverts commit 26b86b7. If you want to ignore something, just add it to your per-user gitignore file in `$XDG_CONFIG_HOME/git/ignore`.
cbacb4f to
a68b9a6
Compare
arogge
approved these changes
Jul 19, 2024
Member
arogge
left a comment
There was a problem hiding this comment.
This got a lot bigger than anticipated. But I think it is finally ready to be merged.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality