VMware Plugin: Adapt to older urllib3 versions#1810
Merged
BareosBot merged 4 commits intobareos:masterfrom May 28, 2024
Merged
Conversation
pstorz
requested changes
May 21, 2024
Member
pstorz
left a comment
There was a problem hiding this comment.
docs: the option fallback_to_full_cbt=no is not described as the other options.
pstorz
approved these changes
May 23, 2024
6 tasks
In urllib3 version 1.26 the parameter method_whitelist was replaced by allowed_methods. The Plugin now detects which parameter to use so that is also works with older versions. Also the new plugin option fallback_to_full_cbt was added, which can be used when it is desired to run a new full level job anyway when incremental CBT is not possible.
ae6007d to
460d2fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In urllib3 version 1.26 the parameter method_whitelist was replaced by allowed_methods. The Plugin now detects which parameter to use so that it also works with older versions.
Also the new plugin option fallback_to_full_cbt was added, which can be used when it is desired to run a new full level job anyway when incremental CBT is not possible.
Fix #1760
Fix #1791
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality