Skip to content

bareos-fd-vmware: Fix Restore as a new VM #1796

Closed
robisetiapermadi wants to merge 1 commit intobareos:masterfrom
robisetiapermadi:dev/robi/master/fix-restoring-as-new-vm
Closed

bareos-fd-vmware: Fix Restore as a new VM #1796
robisetiapermadi wants to merge 1 commit intobareos:masterfrom
robisetiapermadi:dev/robi/master/fix-restoring-as-new-vm

Conversation

@robisetiapermadi
Copy link

@robisetiapermadi robisetiapermadi commented Apr 29, 2024

I have modify the vmware bareos plugin source code, so when restoring as a new VM, the VMware plugin will ignore if the backed up disk is not the same as the new VM.

The check_vm_disks_match() function will check whether the recovery job is restored as a new vm or not. If restored as a new VM, check_vm_disks_match() will return true even if the backed up disk is not the same as the new VM.

This PR should fix bug when VMware Plugin Restore as a new VM that i have mention on this report https://groups.google.com/g/bareos-users/c/RgHCwTfmQ5o/m/d-Q_DpdhAQAJ?utm_medium=email&utm_source=footer

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

When restoring  as a new VM, the VMware plugin will ignore if the backed up disk is not the same as the new VM. 

The check_vm_disks_match() function will check whether the recovery job is restored as a new vm or not. 
If restored as a new VM, check_vm_disks_match() will return true even if the backed up disk is not the same as the new VM.
@robisetiapermadi robisetiapermadi changed the title VMware Plugin: Restore as a new VM VMware Plugin: Fix Restore as a new VM Apr 29, 2024
@robisetiapermadi robisetiapermadi changed the title VMware Plugin: Fix Restore as a new VM bareos-fd-vmware: Fix Restore as a new VM Apr 29, 2024
@sduehr sduehr self-requested a review May 2, 2024 09:23
@sduehr sduehr self-assigned this May 2, 2024
@arogge arogge added this to the 24.0.0 milestone Jun 25, 2024
@sduehr
Copy link
Member

sduehr commented Jun 28, 2024

I created a branch with a changed VMware plugin based on your idea. I added some debug output which could be helpful to analyze the behaviour when VSAN is used. I added a plugin option that must be added on restore to ignore the disks check mismatch when recreating and restoring a VM:
restore_ignore_disks_mismatch=yes

You can download the plugin from my branch at
https://github.com/sduehr/bareos/blob/f1bd841248a87ce3c93dbcdc4fca8606fb532a85/core/src/plugins/filed/python/vmware/bareos-fd-vmware.py

I still need d add documentation for that new plugin option and create a PR.
But if you already want to test it, your feedback is welcome.

@arogge
Copy link
Member

arogge commented Jul 2, 2024

We have an alternative approach to fix this in PR #1876, therefore I'm closing this PR.

@arogge arogge closed this Jul 2, 2024
@arogge arogge removed this from the 24.0.0 milestone Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants