Fix issue #1780 libpng icc profil#1788
Merged
BareosBot merged 2 commits intobareos:masterfrom Apr 23, 2024
Merged
Conversation
sebsura
approved these changes
Apr 23, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
Looks good to me. I could not spot a difference.
Contributor
Author
|
As I should avoid changing image resulting in a bigger size (all +%). I've redone those 5 files (added into commit message) |
7f4b7d2 to
82d81c4
Compare
Use pngcrush to remove any icc profil idat from png
```
find . -type f -iname '*.png' -exec pngcrush -ow -rem allb -reduce {} \;
```
excluded files are the following (resulting in bigger file):
- webui/public/css/32px.png
- webui/public/css/40px.png
- webui/vendor/container-interop/container-interop/docs/images\
/interoperating_containers.png
- webui/vendor/container-interop/container-interop/docs/images\
/priority.png
- webui/vendor/container-interop/container-interop/docs/images\
/side_by_side_containers.png
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
d6e8e84 to
7eb30dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use pngcrush to remove any icc profil idat from png
We also use other options to minimize the global size.
Fix #1780
Note to reviewer: quality of rendered png should be verified if still acceptable.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality