Allow cross-building for Windows on newer compiler#1772
Merged
BareosBot merged 4 commits intobareos:masterfrom Apr 19, 2024
Merged
Allow cross-building for Windows on newer compiler#1772BareosBot merged 4 commits intobareos:masterfrom
BareosBot merged 4 commits intobareos:masterfrom
Conversation
the modern headers declare the VSS_E constants as HRESULT (signed) so we should not cast to unsigned here.
This was referenced Apr 17, 2024
6 tasks
sebsura
approved these changes
Apr 17, 2024
Contributor
sebsura
left a comment
There was a problem hiding this comment.
These changes all make sense to me. If it builds on the newer cross builder, then it can get merged.
| # include "Win2003/vsbackup.h" | ||
|
|
||
| # define VSS_ERROR_OBJECT_ALREADY_EXISTS 0x8004230D | ||
| # define VSS_ERROR_OBJECT_ALREADY_EXISTS ((HRESULT)0x8004230D) |
Contributor
There was a problem hiding this comment.
I wonder where this was taken from. Its not listed as an official return value:
Maybe this was just trial & error ?
Its probably there for a good reason though, so we should not remove it.
| GET_MEDIA_TYPES* pNewBuffer | ||
| = (GET_MEDIA_TYPES*)realloc(pGetMediaTypes, dwBufferSize); | ||
| if (pNewBuffer != pGetMediaTypes) { | ||
| if (pNewBuffer == NULL) { |
Contributor
There was a problem hiding this comment.
This was a nice double free.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement some minor changes to build Bareos with a modern cross compiler.
NOTE: This PR requires #68 to be co-merged.
That other change is also required to make the backport PRs actually build.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality