Conversation
f911651 to
864b45b
Compare
There was a problem hiding this comment.
Sadly i can only add notes to files that you actually touched, so i will write my notes here:
in freebsd/bareos-*.in we need to add a default value or we get an ugly warning:
modified core/platforms/freebsd/bareos-fd.in
@@ -19,4 +19,5 @@ rcvar=bareosfd_enable
command="@sbindir@/bareos-fd"
load_rc_config $name
+: "${bareosfd_enable:=no}"
run_rc_command "$1"see https://docs.freebsd.org/en/articles/rc-scripting/ for reference.
I also have trouble connecting to the director on FreeBSD 14.0. The director seems to crash whenever i try to connect with the console. Ill see if I can get a traceback.
|
It seems like the problem was just that installing |
|
Are you supposed to install |
I think so. IIRC when we dropped MySQL catalog support we decided not to remove the postgresql-package and move its files into the director package. |
|
I pushed a fix for the rcscripts default values. |
sebsura
left a comment
There was a problem hiding this comment.
Thanks for your work! LGTM
- FreeBSD 13.3 - FreeBSD 14.0
cd1724c to
cb23d0f
Compare
This PR adds the following platforms to matrix.yml:
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality