pr-tool: give hint about commit headline length limits#1763
Merged
BareosBot merged 2 commits intobareos:masterfrom Apr 11, 2024
Merged
pr-tool: give hint about commit headline length limits#1763BareosBot merged 2 commits intobareos:masterfrom
BareosBot merged 2 commits intobareos:masterfrom
Conversation
6231e29 to
1899463
Compare
sebsura
reviewed
Apr 8, 2024
Contributor
|
Could you fix the type in the first commit headline ? |
62ecc6b to
1ae9e8a
Compare
Member
Author
|
Fixed type and squashed commits. |
e1f928e to
9cbf954
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
I already wondered several times, about how long headline could be. Changed the code to give a hint. Decided not to mention the 50, to keep the remark as short as possible.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Required backport PRs have been createdSource code quality