dird: disallow running always incremental virtual full jobs with empty jobid list#1738
Merged
BareosBot merged 6 commits intobareos:masterfrom Jul 29, 2024
Merged
Conversation
38be77f to
46e5026
Compare
arogge
requested changes
Jul 1, 2024
Member
arogge
left a comment
There was a problem hiding this comment.
We should probably have a systemtest that checks this actually works.
c325292 to
ed8cdfe
Compare
ed8cdfe to
d0f216b
Compare
We should not run if always incremental is set but no jobids are given since this will otherwise cause the VF to consolidate ALL the current jobs into one full, which is definitely not what you want.
Sometimes -1 is returned on error, and sometimes 0 is returned. Now it always returns -1 on error.
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
d0f216b to
07c7ec0
Compare
arogge
approved these changes
Jul 25, 2024
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
This PR prevents users from accidentally trying to restart a virtualfull job when always incremental is enabled.
Restarting a virtualfull job in that setting used to combine all backup points into one which is not what you want.
This also removes traces of the unfinished legacy feature 'fdcalled'.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests