docs: fix Pool explanation for migration jobs#1728
Merged
BareosBot merged 3 commits intobareos:masterfrom Mar 13, 2024
Merged
Conversation
bruno-at-bareos
requested changes
Mar 7, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks for taking care of that part of the manual.
I'm proposing those wording changes. feel free to accept or adapt.
docs/manuals/source/manually_added_config_directive_descriptions/dir-job-Pool.rst.inc
Outdated
Show resolved
Hide resolved
...manuals/source/manually_added_config_directive_descriptions/dir-job-SelectionPattern.rst.inc
Outdated
Show resolved
Hide resolved
Contributor
|
@sebastianlederer don't forget to also apply bareos-check-sources |
bruno-at-bareos
approved these changes
Mar 12, 2024
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
Thanks, that's a great improvement for our users.
6 tasks
- describe the effect of the Pool statement for Copy and Migration jobs correctly in case of "SQL Query" selection type - fix example configuration
9445cfc to
6cf7fe2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality