VMware Plugin: Backup and Restore NVRAM#1727
Merged
BareosBot merged 2 commits intobareos:masterfrom Mar 26, 2024
Merged
Conversation
6 tasks
cf9c5eb to
2e4f732
Compare
The NVRAM of VMs is now backed up and restored when a VM is recreated. This ensures that EFI enabled VMs will boot successfully. Additionally, the exception handling and error messages in the functions connect_vmware() and retrieve_vcthumbprint() were enhanced. The plugin now makes sure to store all files belonging to a recreated VM in the same directory in VMFS. This commit also contains some changes to improve the pylint score.
283c89c to
2eb5b44
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The NVRAM of VMs is now backed up and restored when a VM is recreated. This ensures that EFI enabled VMs will boot successfully.
Additionally, the exception handling and error messages in the functions connect_vmware() and retrieve_vcthumbprint() were enhanced.
The plugin now makes sure to store all files belonging to a recreated VM in the same directory in VMFS.
This commit also contains some changes to improve the pylint score.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality